-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly test wasm32-unknown-unknown on CI #206
Conversation
I don't think this is something we want to do on CI? Wasm is different enough that we don't really want to test all configurations exhaustively, we just want to make sure that it builds at all and doesn't hit codegen errors. The CI errors here for wasm are sort of just the start I'd imagine for getting the full suite running. |
4e01576
to
a9a76f3
Compare
So this is ready for now. Depending on whether #204 is merged or not, what would remain doing is using the |
So I've added use of I can workaround that here if you want, but the more tests we add directly into the libm crate, the more workarounds are going to be required in the I still think that, since this crate is only used by including it via I suppose we could add |
Note: the failures here are unrelated and due to rust-lang/rust#62574 , should be fixed in nightly soon. |
I'm personally not really super keen on merging this unfortunately. This seems to add a good deal of implementation complexity and infrastructure, which is just yet-again-more to keep working on CI. I don't think we really get any benefit from running these tests on wasm either, so I'm not really sure it's worth the weight of this PR to merge it? |
Currently not all configurations are build for wasm32, and the llvm intrinsics are incorrectly feature gated.